Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000137Mana ClientCorepublic2010-05-06 21:192010-05-21 18:32
ReporterBertram 
Assigned ToJaxad0127 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.0.0 
Target Version1.0.0Fixed in Version1.0.0 
Summary0000137: CPPcheck error report
DescriptionThese errors given by cppcheck should be investigated a bit, I guess:

-mana:
[src/particlecontainer.cpp:80]: (error) Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.

[src/item.h:39]: (error) Class Item which is inherited by class ShopItem does not have a virtual destructor

-manaserv:
[src/chat-server/chathandler.cpp:498]: (error) Unusual pointer arithmetic

[src/game-server/being.cpp:440]: (error) Dangerous iterator usage. After erase the iterator is invalid so dereferencing it or comparing it with another iterator is invalid.
TagsNo tags attached.
Attached Filespatch file icon 0001-Fixes-based-on-cppcheck-errors-report.patch [^] (1,358 bytes) 2010-05-21 18:13 [Show Content]

- Relationships

-  Notes
(0000447)
Jaxad0127 (administrator)
2010-05-07 05:13

I've attached a patch that fixes the issues you found in the client, as well as some I found running the tool myself.
(0000478)
Bertram (developer)
2010-05-20 20:01

The patch is ok.
I'll have a go for the server part.
(0000486)
Bertram (developer)
2010-05-21 18:13

Added a manaserv fix candidate:
0001-Fixes-based-on-cppcheck-errors-report.patch
(0000487)
Jaxad0127 (administrator)
2010-05-21 18:25

Looks fine.
(0000488)
Jaxad0127 (administrator)
2010-05-21 18:29

Client patch pushed as 910ea1476664d8a11d57eaf8ff7f281bcfacd184.
(0000489)
Bertram (developer)
2010-05-21 18:31

Server pushed as 714ebc9d079bbb7d18b9ea6bfe1a20dd0ce190df

- Issue History
Date Modified Username Field Change
2010-05-06 21:19 Bertram New Issue
2010-05-07 05:12 Jaxad0127 Status new => assigned
2010-05-07 05:12 Jaxad0127 Assigned To => Jaxad0127
2010-05-07 05:12 Jaxad0127 File Added: 0001-Fix-some-issues-found-by-Cppcheck.patch
2010-05-07 05:13 Jaxad0127 Note Added: 0000447
2010-05-20 20:01 Bertram Note Added: 0000478
2010-05-21 18:13 Bertram File Added: 0001-Fixes-based-on-cppcheck-errors-report.patch
2010-05-21 18:13 Bertram Note Added: 0000486
2010-05-21 18:24 Jaxad0127 File Deleted: 0001-Fix-some-issues-found-by-Cppcheck.patch
2010-05-21 18:25 Jaxad0127 Note Added: 0000487
2010-05-21 18:29 Jaxad0127 Note Added: 0000488
2010-05-21 18:31 Bertram Note Added: 0000489
2010-05-21 18:32 Bertram Status assigned => resolved
2010-05-21 18:32 Bertram Resolution open => fixed
2010-05-21 18:32 Bertram Fixed in Version => 1.0.0


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker