Mantis Bug Tracker

View Issue Details Jump to Notes ] << ] >> ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000101Mana[All Projects] Generalpublic2010-03-02 21:302010-06-29 20:59
Reporterstrikermdd 
Assigned ToBertram 
PriorityurgentSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0000101: The sell function don't works
Description( in manaserv ...) I create a npc shop, and put the sell function and 3 itens for example, the sell window appears, i select the items i want sell, click in buy ... but the item its not selled, i don't get any money from this ...

And if i don't have any of the items configured in vendor script, the sell window don't appear ... i think a message can be showed in this time, ex : "You don't have any items for sell ..."
Steps To Reproducecreate a npc shop, and put the sell function and 3 itens for example, the sell window appears, i select the items i want sell, click in buy ...
Additional InformationI'd rather commit this:
- sellCount = item->sellCurrentDuplicate(mAmountItems);
+ item->sellCurrentDuplicate(mAmountItems);
+ itemIndex = item->getId();
TagsNo tags attached.
Attached Filespatch file icon 0001-Fixed-the-sell-support-for-ManaServ.patch [^] (914 bytes) 2010-06-22 22:01 [Show Content]

- Relationships
related to 0000078resolvedBertram Mana Server Implement the full "Sell" support 

-  Notes
(0000526)
strikermdd (reporter)
2010-06-20 00:43

this issue continues, i test in the latest git and its the same for the new sell option to sell the any item in my inventory, its show the items, but when i click in the item and in sell, the itens desapears, then when i close and check my inventory, the itens its remains there, and my money don“t change ...
(0000529)
Bertram (developer)
2010-06-20 16:11
edited on: 2010-06-21 07:11

Hi Striker,

I'm aware of it. Yet, I had to upgrade the sell function before being able to test it thoroughly and discover the actual bug.

(0000539)
strikermdd (reporter)
2010-06-22 15:07

ok, this function is still very important to the game.
(0000547)
Bertram (developer)
2010-06-22 22:01

Added a patch that fixes it!
(0000549)
strikermdd (reporter)
2010-06-23 00:10

You can commit this fixes to git ? And you test with the both sell functions ( full inventory and selected items ) ?
(0000550)
Bertram (developer)
2010-06-23 08:08

I'll commit it once I get review from the dev team, and yes, I tested it in both sell functions, multiple times. :)

But I'd be glad if you could also test it and tell me if it's ok.
Download the patch file, and in the mana client source directory, use the git command:
git am patch.file

Then make.
(0000561)
strikermdd (reporter)
2010-06-29 14:10

For me its ok for now, please update this in git.
(0000567)
Bertram (developer)
2010-06-29 20:59

Fixed with commit:
http://www.gitorious.org/mana/mana/commit/f49df74a3a4a1b43f0a7671338733ef05520dcb4 [^]

- Issue History
Date Modified Username Field Change
2010-03-02 21:30 strikermdd New Issue
2010-05-27 12:47 Bertram Relationship added related to 0000078
2010-06-20 00:43 strikermdd Note Added: 0000526
2010-06-20 16:11 Bertram Note Added: 0000529
2010-06-21 07:11 Bertram Note Edited: 0000529 View Revisions
2010-06-22 15:07 strikermdd Note Added: 0000539
2010-06-22 22:00 Bertram Status new => assigned
2010-06-22 22:00 Bertram Assigned To => Bertram
2010-06-22 22:01 Bertram File Added: 0001-Fixed-the-sell-support-for-ManaServ.patch
2010-06-22 22:01 Bertram Note Added: 0000547
2010-06-23 00:10 strikermdd Note Added: 0000549
2010-06-23 08:08 Bertram Note Added: 0000550
2010-06-23 08:09 Bertram Additional Information Updated View Revisions
2010-06-29 14:10 strikermdd Note Added: 0000561
2010-06-29 20:59 Bertram Note Added: 0000567
2010-06-29 20:59 Bertram Status assigned => resolved
2010-06-29 20:59 Bertram Resolution open => fixed


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker